finsh shell 中的BUG问题！

发布于 2010-02-01 12:43:03 浏览：9710 订阅该版

最近看到强大的shell之后，实际动手在我的STM32板子上移植测试了一下，发现有如下几个问题：
我输入如下几个命令(（list)thread()，list(*************************************)，当然这几个命令都不是shell所支持的命令，但是也不应该造成MCU进入FAULT）后，会导致MCU进入FAULT状态。我尝试对这几个问题进行了修改，版主看下是否合理？
 1.输入命令 list)thread()
对如下函数进行了修改，改动部分用斜体加粗表示的。
```static struct finsh_node* proc_cast_expr(struct finsh_parser* self)
{
    enum finsh_token_type token;
    enum finsh_type type;
    struct finsh_node* cast;

next_token(token, &(self->token));
    if (token == finsh_token_type_left_paren)
    {
        type = proc_type(self);
        match_token(token, &(self->token), finsh_token_type_right_paren);

cast = proc_cast_expr(self);
        if(cast != NULL)
        {
            cast->data_type = type; //2010-1-29修正 ( list_mem() ) 命令死机BUG.
        }
        return cast;
    }

finsh_token_replay(&(self->token));
    return proc_unary_expr(self);
}```

2. list(,,)
对如下函数进行了修改，改动部分用斜体加粗表示的。
```static struct finsh_node* proc_param_list(struct finsh_parser* self)
{
    enum finsh_token_type token;
    struct finsh_node *node, *assign;

assign = proc_assign_expr(self);
    if(assign == NULL)
    {
        return NULL; // 添加这里
    }
    node = assign;

next_token(token, &(self->token));
    while (token == finsh_token_type_comma )
    {
        finsh_node_sibling(assign) = proc_assign_expr(self);

if (finsh_node_sibling(assign) != NULL) assign = finsh_node_sibling(assign);
        else finsh_error_set(FINSH_ERROR_EXPECT_OPERATOR);

next_token(token, &(self->token));
    }

finsh_token_replay(&(self->token));

return node;
}```

3.list(,,,,,,,,,,,,,,,,)
对如下函数进行了修改，改动部分用斜体加粗表示的。
```static struct finsh_node* make_sys_node(u_char type, struct finsh_node* node1, struct finsh_node* node2)
{
    struct finsh_node* node;

node = finsh_node_allocate(type);

if (node != NULL)
    {
        finsh_node_child(node) = node1; //2010.1.29修正
    }
    else
        finsh_error_set(FINSH_ERROR_NULL_NODE);

if (node1 != NULL) finsh_node_sibling(node1) = node2;
    else finsh_error_set(FINSH_ERROR_NULL_NODE);

return node;
}```

4. list(*************************************)
     这个命令会将finsh_thread_entry()线程任务的
  堆栈耗尽，而导致MCU进入fualt。即使开辟大的缓存，只有增加命令参数的个数，问题依然存在，这个问题还没找到解决的方案，不知道版主能否提供？
 5.另外，一次发送大于输入缓存长度（默认为255）的数据（中间不要有回车字符），MCU也会进入fault状态。
          
 //此处原程序对line数据越界没有考虑到，导致在进行大量数据包通讯时刻此处溢出
```if(pos >= LINE_BUF_LENGTH)
{
    pos = 0;
}
line[pos] = ch;```

贴图如下：
```finsh>>list)thread()
psr: 0x61004000
 pc: 0x08002cfc
 lr: 0x08003f23
r12: 0x80808080
r03: 0x2000157d
r02: 0x00003b29
r01: 0x2000157d
r00: 0x00000000
hard fault on thread: tshell
 thread  pri  status      sp     stack size max used   left tick  error
-------- ---- ------- ---------- ---------- ---------- ---------- ---
tidle    0x1f ready   0x00000050 0x00000100 0x00000050 0x0000001e 000
tshell   0x14 ready   0x00000230 0x00000800 0x0000042c 0x00000048 000

| /
- RT - Thread Operating System
 / |  0.3.0 build Jan 27 2010
 2006 - 2009 Copyright by rt-thread team
finsh>>list(*************************************)
psr: 0x21000000
 pc: 0x08002f6e
 lr: 0x08002f5d
r12: 0x80808080
r03: 0x20000614
r02: 0x00000010
r01: 0x00000019
r00: 0x00000000
hard fault on thread: ?
                         thread  pri  status      sp     stack size max used   left tick  error
-------- ---- ------- ---------- ---------- ---------- ---------- ---
tidle    0x1f ready   0x00000050 0x00000100 0x00000050 0x0000001b 000
        0x7c 0x00000091 0x00000005 0x00000005 0x2000167c 134229409
         0x00
  | /
- RT - Thread Operating System
 / |  0.3.0 build Jan 27 2010
 2006 - 2009 Copyright by rt-thread team
finsh>>

| /
- RT - Thread Operating System
 / |  0.3.0 build Jan 27 2010
 2006 - 2009 Copyright by rt-thread team
finsh>>
finsh>>
finsh>>
finsh>>
finsh>>
finsh>>
finsh>>list(,,,,,,,,,,,,,,,,,,,,,,,,,,,,,)
psr: 0x41000000
 pc: 0x08002f2c
 lr: 0x08002a33
r12: 0x80808080
r03: 0x2000157d
r02: 0x00000000
r01: 0x2000157d
r00: 0x0800aab5
hard fault on thread: tshell
 thread  pri  status      sp     stack size max used   left tick  error
-------- ---- ------- ---------- ---------- ---------- ---------- ---
tidle    0x1f ready   0x00000050 0x00000100 0x00000050 0x0000001b 000
tshell   0x14 ready   0x00000230 0x00000800 0x00000418 0x00000064 000

| /
- RT - Thread Operating System
 / |  0.3.0 build Jan 27 2010
 2006 - 2009 Copyright by rt-thread team
finsh>>list(,,,)
psr: 0x41000000
 pc: 0x08002f2c
 lr: 0x08002a33
r12: 0x80808080
r03: 0x2000157d
r02: 0x00003b29
r01: 0x2000157d
r00: 0x0800aab5
hard fault on thread: tshell
 thread  pri  status      sp     stack size max used   left tick  error
-------- ---- ------- ---------- ---------- ---------- ---------- ---
tidle    0x1f ready   0x00000050 0x00000100 0x00000050 0x00000016 000
tshell   0x14 ready   0x00000230 0x00000800 0x00000418 0x00000064 000

| /
- RT - Thread Operating System
 / |  0.3.0 build Jan 27 2010
 2006 - 2009 Copyright by rt-thread team
finsh>>l
Unknown symbol
finsh>>
finsh>>
finsh>>list)thread()
psr: 0x61004000
 pc: 0x08002cfc
 lr: 0x08003f23
r12: 0x80808080
r03: 0x2000157d
r02: 0x00003b29
r01: 0x2000157d
r00: 0x00000000
hard fault on thread: tshell
 thread  pri  status      sp     stack size max used   left tick  error
-------- ---- ------- ---------- ---------- ---------- ---------- ---
tidle    0x1f ready   0x00000050 0x00000100 0x00000050 0x0000001e 000
tshell   0x14 ready   0x00000230 0x00000800 0x00000330 0x00000064 000

| /
- RT - Thread Operating System
 / |  0.3.0 build Jan 27 2010
 2006 - 2009 Copyright by rt-thread team
finsh>>```