dataqueue.c中有必要对线程挂起、恢复操作吗？

发布于 2018-08-24 09:19:59 浏览：2520 订阅该版

在dataqueue.c中的 rt_data_queue_pop 和rt_data_queue_push 都对线程有挂起、恢复操作，会对线程的运行有影响吗？

```rt_err_t rt_data_queue_push(struct rt_data_queue *queue,
                            const void *data_ptr,
                            rt_size_t data_size,
                            rt_int32_t timeout)
{
    rt_ubase_t  level;
    rt_thread_t thread;
    rt_err_t    result;
    
    RT_ASSERT(queue != RT_NULL);

result = RT_EOK;
    thread = rt_thread_self();

level = rt_hw_interrupt_disable();
    while (queue->put_index - queue->get_index == queue->size)
    {
        /* queue is full */
        if (timeout == 0)
        {
            result = -RT_ETIMEOUT;

goto __exit;
        }

/* current context checking */
        RT_DEBUG_NOT_IN_INTERRUPT;

/* reset thread error number */
        thread->error = RT_EOK;
        
        /* suspend thread on the push list */
        rt_thread_suspend(thread);
        rt_list_insert_before(&(queue->suspended_push_list), &(thread->tlist));
        /* start timer */
        if (timeout > 0)
        {
            /* reset the timeout of thread timer and start it */
            rt_timer_control(&(thread->thread_timer),
                             RT_TIMER_CTRL_SET_TIME,
                             &timeout);
            rt_timer_start(&(thread->thread_timer));
        }

/* enable interrupt */
        rt_hw_interrupt_enable(level);

/* do schedule */
        rt_schedule();

/* thread is waked up */
        result = thread->error;
        level = rt_hw_interrupt_disable();
        if (result != RT_EOK) goto __exit;
    }

queue->queue[queue->put_index % queue->size].data_ptr  = data_ptr;
    queue->queue[queue->put_index % queue->size].data_size = data_size;
    queue->put_index += 1;

/* there is at least one thread in suspended list */
    if (!rt_list_isempty(&(queue->suspended_pop_list)))
    {
        /* get thread entry */
        thread = rt_list_entry(queue->suspended_pop_list.next,
                               struct rt_thread,
                               tlist);

/* resume it */
        rt_thread_resume(thread);
        rt_hw_interrupt_enable(level);

/* perform a schedule */
        rt_schedule();

return result;
    }

__exit:
    rt_hw_interrupt_enable(level);
    if ((result == RT_EOK) && queue->evt_notify != RT_NULL)
    {
        queue->evt_notify(queue, RT_DATAQUEUE_EVENT_PUSH);
    }

return result;
}```

![1535073548(1).jpg](https://oss-club.rt-thread.org/uploads/201808/24/091954q38c69610x7w6zx3.jpg)

![1535073566(1).jpg](https://oss-club.rt-thread.org/uploads/201808/24/091954ldy7z70zy99ewsec.jpg)